Explicity use IndexMap::swap_remove to silence warnings

greatest-ape · Feb 6, 2024 · e705c03 · e705c03
1 parent 0b6a02e
commit e705c03
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/crates/http/src/workers/swarm/storage.rs b/crates/http/src/workers/swarm/storage.rs
@@ -433,7 +433,7 @@ impl<I: Ip> LargePeerMap<I> {
     }
 
     fn remove_peer(&mut self, key: &ResponsePeer<I>) -> Option<Peer> {
-        let opt_removed_peer = self.peers.remove(key);
+        let opt_removed_peer = self.peers.swap_remove(key);
 
         if let Some(Peer {
             is_seeder: true, ..

diff --git a/crates/udp/src/workers/statistics/mod.rs b/crates/udp/src/workers/statistics/mod.rs
@@ -97,7 +97,7 @@ pub fn run_statistics_worker(
                             *count -= 1;
 
                             if *count == 0 {
-                                peers.remove(&peer_id);
+                                peers.swap_remove(&peer_id);
                             }
                         }
                     }

diff --git a/crates/udp/src/workers/swarm/storage.rs b/crates/udp/src/workers/swarm/storage.rs
@@ -407,7 +407,7 @@ impl<I: Ip> LargePeerMap<I> {
     }
 
     fn remove_peer(&mut self, key: &ResponsePeer<I>) -> Option<Peer> {
-        let opt_removed_peer = self.peers.remove(key);
+        let opt_removed_peer = self.peers.swap_remove(key);
 
         if let Some(Peer {
             is_seeder: true, ..

diff --git a/crates/ws/src/workers/swarm/storage.rs b/crates/ws/src/workers/swarm/storage.rs
@@ -356,7 +356,7 @@ impl TorrentData {
                     peer.valid_until = valid_until;
                 }
                 PeerStatus::Stopped => {
-                    let peer = entry.remove();
+                    let peer = entry.swap_remove();
 
                     if peer.seeder {
                         self.num_seeders -= 1;
@@ -477,7 +477,7 @@ impl TorrentData {
 
             if answer_receiver
                 .expecting_answers
-                .remove(&expecting_answer)
+                .swap_remove(&expecting_answer)
                 .is_some()
             {
                 let answer_out_message = AnswerOutMessage {
@@ -519,7 +519,7 @@ impl TorrentData {
         peer_id: PeerId,
         #[cfg(feature = "metrics")] peer_gauge: &::metrics::Gauge,
     ) {
-        if let Some(peer) = self.peers.remove(&peer_id) {
+        if let Some(peer) = self.peers.swap_remove(&peer_id) {
             if peer.seeder {
                 self.num_seeders -= 1;
             }