Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignoring columns from has_one association for missing_unique_indexes #137

Conversation

fatkodima
Copy link
Contributor

class User
  has_one :account
end

class Account
end

To disable missing_unique_indexes for checking unique index on accounts.user_id, we currently should add ignore_columns: ["User(user_id)"] to the config, which does not make sense. This PR fixes that so we should write as ignore_columns: ["Account(user_id)"].

@gregnavis gregnavis force-pushed the master branch 2 times, most recently from 168d951 to d322a6e Compare October 20, 2023 14:24
gregnavis
gregnavis previously approved these changes Jun 7, 2024
@gregnavis gregnavis added bug waiting Waiting for updates from contributors labels Aug 27, 2024
@gregnavis
Copy link
Owner

@fatkodima, could you rebase the PR?

@fatkodima fatkodima force-pushed the fix-ignoring-has_one-columns-for-missing_unique_indexes branch from c43c810 to e8f29c8 Compare August 27, 2024 16:03
@fatkodima
Copy link
Contributor Author

Rebased. Turns out, the code change is not needed now, only the test that is useful.

@gregnavis gregnavis removed the waiting Waiting for updates from contributors label Aug 27, 2024
@gregnavis
Copy link
Owner

@fatkodima, interesting! Do you happen to know why the issue is gone now?

@gregnavis
Copy link
Owner

@fatkodima, the linter is failing.

@gregnavis gregnavis added waiting Waiting for updates from contributors qa Pull requests that improve project quality assurance and removed bug labels Aug 27, 2024
@gregnavis gregnavis added this to the 1.15 milestone Aug 27, 2024
@fatkodima
Copy link
Contributor Author

This was fixed in b013fc0 🤷

Somehow this PR is a duplicate. We need to merge PRs faster 😅

@fatkodima fatkodima closed this Aug 27, 2024
@fatkodima fatkodima deleted the fix-ignoring-has_one-columns-for-missing_unique_indexes branch August 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Pull requests that improve project quality assurance waiting Waiting for updates from contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants