Fix missing_non_null_constraint when there are no STI children for STI-like parent
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnavis
force-pushed
the
master
branch
2 times, most recently
from
168d951
to
d322a6e
Compare
|
@fatkodima, I don't believe this PR is correct. I think it's perfectly valid to instantiate the base class of an STI hierarchy: in this case A proper fix for the problem would be to skip the check on the |
fatkodima
force-pushed
the
fix-missing_non_null_constraint-when-no-sti-child
branch
from
dca8fb3
to
36ff5f2
Compare
|
Agreed, fixed. |
|
Perfect! Thank you, @fatkodima. |
gregnavis
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the STI-like parent model has no children, all the
nextbranches in thedetectmethod pass (specificallynext if !concrete_models.all? { |model| non_null_needed?(model, column) }) andMissingNonNullConstrainterroneously adds offenses for the column. See a test case for the example.