Include table name in the message for extraneous_indexes
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnavis
previously approved these changes
Jun 13, 2023
gregnavis
force-pushed
the
improve-message-for-extraneous_indexes
branch
from
f4b7be5
to
4fdcc4b
Compare
gregnavis
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently tested this gem on a project which has quite a few matviews in the database and a foreign wrapper for MySQL, but still is using
schema.rbwithout dumped them there (don't ask why). And whenextraneous_indexesreported extra indexes, it hasn't mentioned where these indexes are defined, so it was quite a challenge to find it throughpsql. This PR simplifies such debugging for future users.