Fix missing_presence_validation for custom attributes with defaults
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
fix-missing_presence_validation-for-attrs-with-default
branch
2 times, most recently
from
d5ab64b
to
02d0706
Compare
fatkodima
force-pushed
the
fix-missing_presence_validation-for-attrs-with-default
branch
from
02d0706
to
36ffc52
Compare
|
Too much version crap in this PR. I would still recommend dropping support for older railses.
|
|
I'm closing this for now as I don't believe that the original report was natural bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154.
This PR fixes
missing_presence_validationnot only forenums (which is internally defined as anattribute), but for anyattributehaving a default.