Suggest using config file with .rb extension
#161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
reviewed
Nov 24, 2023
gregnavis
requested changes
Dec 4, 2023
There was a problem hiding this comment.
@fatkodima, I wouldn't like to support two different configuration files. Let's also show a warning when the old file is used, so that users are aware we are migrating to .active_record_doctor.rb.
I suggest the following wording:
WARNING: configuration was loaded from .active_record_doctor, but it's support will be dropped in favor of .active_record_doctor.rb. Please rename the configuration file to avoid errors in the future.
|
@gregnavis Do you feel #162 solves what you're looking for? Feedback is welcome. |
|
@jdufresne, I hadn't noticed you also opened a PR when I was reviewing this. I opened another PR and wanted to ask you and @fatkodima for a quick review. Let me leave some feedback on your PR, so that it's clear why I chose a slightly different path. Thank you for your contributions! |
|
Closing in favor of #166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159.
Backwards compatibility is preserved to also accept
.active_record_doctorfiles by default (without extension), if present.