Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pip and pip-tools from requirements #254

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

fievelk
Copy link
Contributor

@fievelk fievelk commented Sep 1, 2021

Adding these two packages to the requirements is considered to be unsafe, and it's also generating errors/warnings because of incompatibilities with some of our dependencies. Updating pip and pip-tools should be manually done by the dev.

  • remove pip and pip-tools from explicit requirements
  • re-compile requirements (using pip-compile from pip-tools)

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #254 (f5aaa4b) into master (2b28db3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   46.52%   46.52%           
=======================================
  Files          49       49           
  Lines        2730     2730           
  Branches      551      551           
=======================================
  Hits         1270     1270           
  Misses       1405     1405           
  Partials       55       55           

Copy link
Contributor

@faizan2590 faizan2590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +7 to +8
appdirs==1.4.4
# via virtualenv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these rendered like this? I recall that this is not the first time, do you have any clue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New pip-tools version AFAIK

Copy link
Contributor Author

@fievelk fievelk Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hassan754 @spyrostz exactly: jazzband/pip-tools#1237. This is done to avoid git conflicts.

@fievelk fievelk merged commit 8146937 into master Sep 2, 2021
@Hassan754 Hassan754 deleted the remove-pip-setuptools-deps branch September 2, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants