Swagger: JSON definitions aren't CamelCased

[utrack]

Example:

message Foo {
  string bar_baz = 1;
}

Go generator generates CamelCased JSON field json="barBaz,omitempty", but gen-swagger takes raw name (bar_baz).

https://github.com/golang/protobuf/blob/master/protoc-gen-go/generator/generator.go#L1781

[cheung-chifung]

same problem.

I think the f.GetName() in following code should be f.GetJsonName().

schema.Properties = append(schema.Properties, keyVal{f.GetName(), fieldValue})

https://github.com/grpc-ecosystem/grpc-gateway/blob/master/protoc-gen-swagger/genswagger/template.go#L186

[achew22]

There has been a lot of work on the swagger definitions since this was filed and I think it's likely that this is fixed. If you have more issues please reopen/file a new issue.

[alexleigh]

This is still an issue. f.GetName() is still being used, resulting in snake_case names rather than camelCase names in the generated swagger definitions.

[achew22]

@alexleigh, looks like it is. Would you mind contributing a patch and helping out the community? It would be a great starter to get into the project. Just remember to run make examples afterward to ensure update the goldens.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[johanbrandhorst]

I think we want to fix this for v2, if it's still an issue.

[johanbrandhorst]

Fixed in #1376