Minimize public API #1249
Merged
Minimize public API #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
limit-public-api
branch
2 times, most recently
from
c3ed09a
to
9d405d0
Compare
As previously attempted on v1, so it shall be on v2. We want to minimize the public API surface to more easily allow changes that won't break users.
johanbrandhorst
force-pushed
the
limit-public-api
branch
from
9d405d0
to
24fa0eb
Compare
achew22
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously attempted on v1, so it shall be on v2.
We want to minimize the public API surface to more easily
allow changes that won't break users.