docs: add example customizing unmarshal options #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Codecov Report
@@ Coverage Diff @@
## master #1335 +/- ##
=======================================
Coverage 54.14% 54.14%
=======================================
Files 42 42
Lines 4375 4375
=======================================
Hits 2369 2369
Misses 1750 1750
Partials 256 256 Continue to review full report at Codecov.
|
johanbrandhorst
requested changes
May 15, 2020
Signed-off-by: Stephan Renatus <srenatus@chef.io> Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com>
|
@johanbrandhorst thanks for the review. Applied your suggestion. I think this could be something for #1223, too: make this easier. 😉 |
johanbrandhorst
approved these changes
May 15, 2020
|
Thanks for your contribution! Could you cherry pick this against v2 please? |
srenatus
added a commit
to srenatus/grpc-gateway
that referenced
this pull request
May 15, 2020
* docs: add example customizing unmarshal options Signed-off-by: Stephan Renatus <srenatus@chef.io> * Update docs/_docs/customizingyourgateway.md Signed-off-by: Stephan Renatus <srenatus@chef.io> Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com> Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com>
johanbrandhorst
added a commit
that referenced
this pull request
May 15, 2020
* docs: add example customizing unmarshal options Signed-off-by: Stephan Renatus <srenatus@chef.io> * Update docs/_docs/customizingyourgateway.md Signed-off-by: Stephan Renatus <srenatus@chef.io> Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com> Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to adjust prose and code as you see fit! 😃