Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement last-match-wins behaviour in mux #1384

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

johanbrandhorst
Copy link
Collaborator

In accordance with the http.proto spec, we should
use last-match-wins to determine which handler
is chosen if two are matched.

See #224
for more discussion.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #1384 into v2 will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #1384      +/-   ##
==========================================
- Coverage   58.95%   58.81%   -0.14%     
==========================================
  Files          32       32              
  Lines        3927     3904      -23     
==========================================
- Hits         2315     2296      -19     
+ Misses       1358     1354       -4     
  Partials      254      254              
Impacted Files Coverage Δ
internal/descriptor/registry.go 59.61% <ø> (+0.90%) ⬆️
...c-gen-grpc-gateway/internal/gengateway/template.go 79.79% <ø> (-0.79%) ⬇️
runtime/mux.go 58.87% <100.00%> (-2.19%) ⬇️
runtime/pattern.go 88.43% <100.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e090d4a...5bca97b. Read the comment docs.

In accordance with the http.proto spec, we should
use last-match-wins to determine which handler
is chosen if two are matched.

See #224
for more discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants