Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gorelease base for v1 #1748

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Update gorelease base for v1 #1748

merged 1 commit into from
Oct 14, 2020

Conversation

johanbrandhorst
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #1748 into v1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v1    #1748   +/-   ##
=======================================
  Coverage   53.38%   53.38%           
=======================================
  Files          42       42           
  Lines        3902     3902           
=======================================
  Hits         2083     2083           
  Misses       1562     1562           
  Partials      257      257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384bafa...ec889c9. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit f6391fc into v1 Oct 14, 2020
@johanbrandhorst johanbrandhorst deleted the update-gorelease-base-v1 branch October 14, 2020 08:32
johanbrandhorst added a commit that referenced this pull request Nov 25, 2020
* Update v1 renovate config (#1738)

Not even sure if renovate cares to check this branch
but it can't hurt.

* Update gorelease base for v1 (#1748)

* feat: protoc-gen-swagger: Implement Response Header(s) object, Implement Field Enum,Example&Format attributes #1729

* fix: resolve linting errors

* fix: running  per CI

* fix: Resolve PR requests
* a bunch of whitespace/format changes... have since added this to my IDE
* remove any.Any objects, and convert them to string
* move runtime regex strings to global variables
* update examples
* update tests

* fix: Running go mode tidy to cleanup go.mod and go.sum

* fix: Resolving PR comments
* remove regex logic, and update functions to use simple booleans
* cleanup example proto
* enforce CanonicalMIMEHeaderKey for header name

* Update protoc-gen-swagger/genswagger/template.go

simplifying string check

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

* Update protoc-gen-swagger/genswagger/template.go

fix: remove string comparisons

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

* fix: resolving MR requests

* fix: unqouting error

* Update protoc-gen-swagger/genswagger/template.go

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

* Update protoc-gen-swagger/genswagger/template.go

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

* fix: adding requested changes
* parse unsigned ints with strconv.ParseUint
* update unqoute logic

* Updating integer switch

* Minor nits

* Remove extra newlines

* Pulling in changes for v2

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants