Adapt usage instructions to use protoc-gen-go-grpc

[olivierlemasle]

References to other Issues or PRs

N/A

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

This reflect recent changes in https://grpc.io/docs/languages/go/quickstart/ to use new protoc-gen-go-grpc.

Also remove a duplicated paragraph.

[codecov-io]

Codecov Report

Merging #1755 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1755   +/-   ##
=======================================
  Coverage   58.74%   58.74%           
=======================================
  Files          33       33           
  Lines        3624     3624           
=======================================
  Hits         2129     2129           
  Misses       1237     1237           
  Partials      258      258           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aab03c...115adc7. Read the comment docs.

[johanbrandhorst]

Thanks a lot for this update, and for removing the duplicate installation instructions 😂. I'm worried what other merge mistakes I made 😬.

[olivierlemasle]

@johanbrandhorst I did not find any other duplicated paragraph in the README ;-)

[johanbrandhorst]

Having made this switch, we should replace any uses of plugins=grpc in the repo. I can see it's still there in a few docs files. Sorry I missed it on the first review.

[olivierlemasle]

I've updated the PR; I hope instructions are now correct.
I did not test Cygwin instructions, as I do not have a Windows environment at hand, but they might need to be updated.

[johanbrandhorst]

We should drop the -u -v as well, this is not how things are installed anymore.

[olivierlemasle]

@johanbrandhorst I've updated the PR with the _opt format, and fixed some other small issues (missing v2 or some swagger left).

However, I did not update Cygwin instructions. I've installed Cygwin on a Windows VM to test the Cygwin instructions with an up-to-date Golang version (1.15 instead of 1.8). The majority of the instructions were now unnecessary (the errors mentioned with go get seem to be solved now with Go modules, and I did not have to adapt protoc commands). I even doubt if this page is still needed, but as I have no experience with Cygwin and even less with Go/protoc on cygwin/Windows, I do not want to handle this.

[johanbrandhorst]

@johanbrandhorst I've updated the PR with the _opt format, and fixed some other small issues (missing v2 or some swagger left).

However, I did not update Cygwin instructions. I've installed Cygwin on a Windows VM to test the Cygwin instructions with an up-to-date Golang version (1.15 instead of 1.8). The majority of the instructions were now unnecessary (the errors mentioned with go get seem to be solved now with Go modules, and I did not have to adapt protoc commands). I even doubt if this page is still needed, but as I have no experience with Cygwin and even less with Go/protoc on cygwin/Windows, I do not want to handle this.

😂 I can't believe you booted a windows VM to test this, that's some serious dedication. Yeah I'd be happy to remove the Cygwin instructions as well, they have surely bitrotted beyond usefulness. Thanks so much for your help!

[johanbrandhorst]

Some more picky comments while we're at it, thank you so much for this cleanup!

[johanbrandhorst]

Great, thanks so much for this Olivier 😄