Emit default values in marshalled JSON (with tests) #628
Conversation
In order to make APIs more restful, require the marshaler to emit
default values. By default, it omits empty types. This causes
unexpected REST behavior by omitting all false values or zero-valued
integers.
If you like to override its behavior back, use the WithMarshalerOption:
```go
gwmux := runtime.NewServeMux(runtime.WithMarshalerOption(runtime.MIMEWildcard, &runtime.JSONPb{OrigName: true, EmitDefaults: false}))
```
Closes grpc-ecosystem#233
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
flw-cn
force-pushed
the
feature/origin-issue-233-emit-default
branch
from
79a8e83
to
f588bc4
Compare
|
Sorry, I notice that there is already a PR #540 do the same thing, even more. So, just close this. |
Repost for closes #233, #242 and #508. cc @ornithocoder @philipithomas @achew22.