Assign primary handler before other configuration #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/improve-tracking-handler
branch
from
9b9e5f7
to
3435c1b
Compare
CarnaViire
reviewed
May 30, 2024
CarnaViire
reviewed
May 30, 2024
Yes, it's built for .NET Standard 2.0. |
CarnaViire
reviewed
Jun 3, 2024
CarnaViire
reviewed
Jun 3, 2024
JamesNK
force-pushed
the
jamesnk/improve-tracking-handler
branch
from
b26abba
to
bc0cf8e
Compare
JamesNK
changed the title
oguzhand95
pushed a commit
to cerbos/cerbos-sdk-net
that referenced
this pull request
Jul 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Grpc.Net.Client](https://github.com/grpc/grpc-dotnet) | `2.63.0` -> `2.64.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary> ### [`v2.64.0`](https://github.com/grpc/grpc-dotnet/releases/tag/v2.64.0) #### What's Changed - doc: fix typo by [@​WeihanLi](https://github.com/WeihanLi) in [grpc/grpc-dotnet#2432 - doc: fix typo by [@​WeihanLi](https://github.com/WeihanLi) in [grpc/grpc-dotnet#2431 - ci: upgrade checkout action version by [@​WeihanLi](https://github.com/WeihanLi) in [grpc/grpc-dotnet#2434 - build: configure rollForward in global.json by [@​WeihanLi](https://github.com/WeihanLi) in [grpc/grpc-dotnet#2437 - Support some HttpClientAction settings and log debug message instead of an error by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2448 - Assign primary handler before other configuration by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2445 - Update various package versions by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2453 - Update Grpc.Tools to 2.64.0 by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2456 - Change functional tests to use dynamic ports by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2458 - Add WriteResponseHeadersAsync test by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2452 - Update repo for .NET 9 by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2457 - Fix flaky ConnectTimeout_MultipleCalls_AttemptReconnect test by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2460 - Bump branch version to 2.64.0-pre1 by [@​stanley-cheung](https://github.com/stanley-cheung) in [grpc/grpc-dotnet#2471 - \[2.64.x] Update Native.DetectWindowsVersion() to consider Windows Server 2019 to be Window Server by [@​JamesNK](https://github.com/JamesNK) in [grpc/grpc-dotnet#2473 - Bump version to 2.64.0 by [@​stanley-cheung](https://github.com/stanley-cheung) in [grpc/grpc-dotnet#2487 **Full Changelog**: grpc/grpc-dotnet@v2.63.0...v2.64.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2NpIiwiYm90cyIsImtpbmQvY2hvcmUiXX0=--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrimaryHandler is non-nullable so we shouldn't be setting it to null. This will cause problems when combined with changes in dotnet/runtime#101808
This PR assigns primary handler at the start of config and tracks the initial value to see whether it's changed at post-configure if not valid.