Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.23.x] Server call handler logger name shouldn't be service type name #500

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 9, 2019

Cherry picked from #497

I don't think this needs to be in 2.23.1, but it is very low risk change and it would be nice to be consistent with the logger name in the first release.

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtattermusch jtattermusch merged commit 5458bc0 into grpc:v2.23.x Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants