Validate gRPC response protocol is not downgraded #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @jtattermusch what does C Core do here? |
|
@yashykt do you know the answer? (if not you, who does?) |
|
gRPC does not work with HTTP/1.1. It would need HTTP/2. I don't remember the exact behavior from the server in case the client sends HTTP/1.1 but I am guessing that it would be something like a bad response. |
JunTaoLuo
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient sends HTTP/1.1 and HTTP/2 with ALPN negotiation, so a server could potentially start a HTTP/1.1 connection if it doesn't support HTTP/2.
Validate response is always HTTP/2.
@jtattermusch What does Grpc.Core do here? I'm guessing it would only ever allow HTTP/2.