Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log message read cancellation as an error #697

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Don't log message read cancellation as an error #697

merged 1 commit into from
Dec 19, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 17, 2019

Fixes #687

jtattermusch
jtattermusch approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JamesNK JamesNK merged commit 89a95c3 into grpc:master Dec 19, 2019
@JamesNK JamesNK deleted the jamesnk/read-cancellation-error branch December 19, 2019 05:42
@JamesNK JamesNK mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelling IAsyncStreamReader.MoveNext logs error
2 participants
@JamesNK @jtattermusch