Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server reflection tutorial #4593

Closed
dfawley opened this issue Jul 12, 2021 · 5 comments · Fixed by #5824
Closed

Update server reflection tutorial #4593

dfawley opened this issue Jul 12, 2021 · 5 comments · Fixed by #5824
Assignees
@buzzsurfr
Labels
fixit P3 Type: Documentation Documentation or examples

Comments

@dfawley
Copy link
Member

dfawley commented Jul 12, 2021 •
edited
Loading

https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md#enable-server-reflection

Does not specify the --channel_creds_type=local flag is needed (EDIT: it isn't needed in OSS, since the default is local credentials). Also consider updating to use grpcurl instead of grpc_cli.
@dfawley dfawley added P3 fixit and removed P2 labels May 16, 2022
@easwars
Copy link
Contributor

easwars commented Nov 28, 2022

@buzzsurfr : Is this something you would be interested in taking on, once #5684 is done?

@buzzsurfr
Copy link
Contributor

Sure thing.

@easwars
Copy link
Contributor

easwars commented Nov 28, 2022

Thank you very much !!

@buzzsurfr
Copy link
Contributor

If we update to use grpcurl, then the --channel_creds_type flag is no longer relevant. Should we include instructions for both or just move to grpcurl?

@easwars
Copy link
Contributor

easwars commented Nov 28, 2022

I think moving to grpcurl should be good enough.

@buzzsurfr buzzsurfr mentioned this issue Nov 29, 2022
Merged
dfawley pushed a commit that referenced this issue Dec 20, 2022
@buzzsurfr
examples: update server reflection tutorial (#5824)
4f16fbe 
Fixes #4593
easwars pushed a commit to easwars/grpc-go that referenced this issue Dec 21, 2022
@buzzsurfr @easwars
examples: update server reflection tutorial (grpc#5824)
95e55f9 
Fixes grpc#4593
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@buzzsurfr buzzsurfr

Labels
fixit P3 Type: Documentation Documentation or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation: update server reflection tutorial buzzsurfr/grpc-go
3 participants
@easwars @buzzsurfr @dfawley