Suppress server log message when EOF without receiving data for preface #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menghanl is already working on adding different levels to logging. This should be taken care of there. Menghan can confirm further when he's back. |
|
@menghanl Any chance your changes are going in soon? I have to keep moving the patch forward when I pull due to current code being super-noisy when used behind a tcp balancer. |
|
The first step (#922) should be done by the end of this week. |
menghanl
reviewed
May 19, 2017
transport/http2_server.go
Outdated
| grpclog.Printf("transport: http2Server.HandleStreams failed to receive the preface from client: %v", err) | ||
| if n, err := io.ReadFull(t.conn, preface); err != nil { | ||
| // Only log if it isn't a simple tcp accept check (ie: tcp balancer doing open/close socket) | ||
| if n > 0 || err != io.EOF { |
There was a problem hiding this comment.
Let's just need to check io.EOF here. If n>0, err will be ErrUnexpectedEOF.
From the doc of ReadFull:
The error is EOF only if no bytes were read.
If an EOF happens after reading some but not all the bytes,
ReadFull returns ErrUnexpectedEOF.
There was a problem hiding this comment.
makes sense, updated...
menghanl
approved these changes
May 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a TCP load balancer (ie: AWS ELB), they do health checks by simply opening a connection to your port and then closing it.
Just to test if you can accept a connection.
Currently, this causes a log message of:
This change suppresses that log message if, and only if, no bytes were received.
Basically, it allows a GRPC server to be used behind a simple TCP load balancer without spamming your logs.