Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: fix client send preface problems #2380

Merged
merged 9 commits into from
Oct 18, 2018

Commits on Oct 16, 2018

  1. internal: fix client send preface problems

    This CL fixes two problems:
    
    - In clientconn_state_transitions.go, each time we set up a server to send
    SETTINGS, we should also set up the server to read. This allows the client
    to successfully send its SETTINGS.
    
    - In clientconn.go, we incorrectly transitioned into TRANSIENT FAILURE when
    the http2client returned an error. This should be handled in the outer
    resetTransport main reset loop. The reason this became a problem is that the
    outer resetTransport has very specific conditions around when to transition
    into TRANSIENT FAILURE that the egregious transition did not have. So, it
    could transition into TRANSIENT FAILURE after failing to dial, even if it
    were trying to connect to a non-final address in the list of addresses.
    jeanbza committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    decf313 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. code golf

    jeanbza committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    dbe5cea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c8ae94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fdbacdb View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. address review comments

    jeanbza committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    0be9a00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9794f38 View commit details
    Browse the repository at this point in the history
  3. update pipelistener logic

    jeanbza committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    1e93523 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fd566b1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2b3e9af View commit details
    Browse the repository at this point in the history