-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: fix client send preface problems #2380
Merged
Merged
Commits on Oct 16, 2018
-
internal: fix client send preface problems
This CL fixes two problems: - In clientconn_state_transitions.go, each time we set up a server to send SETTINGS, we should also set up the server to read. This allows the client to successfully send its SETTINGS. - In clientconn.go, we incorrectly transitioned into TRANSIENT FAILURE when the http2client returned an error. This should be handled in the outer resetTransport main reset loop. The reason this became a problem is that the outer resetTransport has very specific conditions around when to transition into TRANSIENT FAILURE that the egregious transition did not have. So, it could transition into TRANSIENT FAILURE after failing to dial, even if it were trying to connect to a non-final address in the list of addresses.
Configuration menu - View commit details
-
Copy full SHA for decf313 - Browse repository at this point
Copy the full SHA decf313View commit details
Commits on Oct 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dbe5cea - Browse repository at this point
Copy the full SHA dbe5ceaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c8ae94 - Browse repository at this point
Copy the full SHA 9c8ae94View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdbacdb - Browse repository at this point
Copy the full SHA fdbacdbView commit details
Commits on Oct 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0be9a00 - Browse repository at this point
Copy the full SHA 0be9a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9794f38 - Browse repository at this point
Copy the full SHA 9794f38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e93523 - Browse repository at this point
Copy the full SHA 1e93523View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd566b1 - Browse repository at this point
Copy the full SHA fd566b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b3e9af - Browse repository at this point
Copy the full SHA 2b3e9afView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.