Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: fix GO_AWAY deadlock #2391

Merged
merged 2 commits into from
Oct 19, 2018
Merged

internal: fix GO_AWAY deadlock #2391

merged 2 commits into from
Oct 19, 2018

Commits on Oct 19, 2018

  1. internal: fix GO_AWAY deadlock 

    A deadlock can occur when a GO_AWAY is followed by a connection closure. This
happens because onClose needlessly closes the current ac.transport: if a
GO_AWAY already occured, and the transport was already reset, then the later
closure (of the original address) sets ac.transport - which is now healthy -
to nil.

The manifestation of this problem is that picker_wrapper spins forever trying
to use a READY connection whose ac.transport is nil.
    @jeanbza
    jeanbza committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    eb547cf View commit details
    Browse the repository at this point in the history

  2. replace poll conn2Ready with notifying listener

    @jeanbza
    jeanbza committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    981c5e4 View commit details
    Browse the repository at this point in the history