interop: update --fail_on_failed_rpc to wait for initial success #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Jul 27, 2020
interop/xds/client/client.go
Outdated
| @@ -58,6 +58,7 @@ var ( | |||
| mu sync.Mutex | |||
| currentRequestID int32 | |||
| watchers = make(map[statsWatcherKey]*statsWatcher) | |||
| rpcSucceeded bool | |||
There was a problem hiding this comment.
There's no atomic boolean, but you can use int + atomic, like this: https://github.com/grpc/grpc-go/blob/master/internal/profiling/profiling.go#L49
menghanl
reviewed
Jul 27, 2020
interop/xds/client/client.go
Outdated
| ) | ||
|
|
||
| type statsService struct { | ||
| testpb.UnimplementedLoadBalancerStatsServiceServer | ||
| } | ||
|
|
||
| func HasRpcSucceeded() bool { |
There was a problem hiding this comment.
No need to export this and the other function.
RPC, not Rpc, otherwise go lint will complain.
And call this setRPCSucceeded()?
There was a problem hiding this comment.
Awesome, I am up to page 3 of a tour of Go now: https://tour.golang.org/basics/3 :-)
Done (I think!)
ericgribkoff
force-pushed
the
delayed_fail_on_failed_rpc
branch
from
10bf0ee
to
8e08486
Compare
|
merged this with master to incorporate the new changes from #3737 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to grpc/grpc#23629
cc @menghanl