-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds/kokoro: install go 1.17, and retry go build #5015
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aef3beb
[xds_sh] xds/kokoro: install go 1.16, and retry go build for at most …
menghanl 7feb843
[xds_sh] update to 1.17.3
menghanl 5ef3eef
[xds_sh] c1
menghanl bb3f70b
[xds_sh] try curl
menghanl 5aa6c0e
[xds_sh] retry curl
menghanl f1ede36
[xds_sh] l
menghanl 32aa96e
[xds_sh] ln
menghanl 228443d
[xds_sh] drop v for tar
menghanl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,14 @@ shopt -s extglob | |
branch="${branch//[[:space:]]}" | ||
branch="${branch##remotes/origin/}" | ||
shopt -u extglob | ||
go build | ||
# Install a version of Go supported by gRPC for the new features, e.g. | ||
# errors.Is() | ||
sudo apt-get install -y wget | ||
wget https://go.dev/dl/go1.17.3.linux-amd64.tar.gz | ||
sudo tar -C /usr/local -xvf go1.17.3.linux-amd64.tar.gz | ||
sudo cp /usr/local/go/bin/go /usr/bin/go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
# Retry go build on errors (e.g. go get connection errors), for at most 3 times | ||
for i in 1 2 3; do go build && break || sleep 5; done | ||
popd | ||
|
||
git clone -b "${branch}" --single-branch --depth=1 https://github.com/grpc/grpc.git | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
curl
is already in the VM, it would be preferable to use it. Otherwise thisapt install
is another potential point of failure.Also, should these things be retried for the same reason as
go build
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done