Import examples from core repository #2474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new push to expand our examples significantly, I think it makes more sense for the examples to be here in the same repository as the code than for them to be in the core repository.
This is roughly a copy of the core repository's examples/node directory, with a few changes:
package.json
file into the main one.This change will be made along with a change to the core repository replacing the examples there with links to this directory, and a change to the grpc.io repository updating references to these examples.