-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go quick-start once cmd/protoc-gen-go-grpc is at v1.0 #298
Comments
@dfawley - I don't think that I can update the quick-start page yet, right? That is, we're still required to use |
In #304, the - grpc_go_release_tag: v1.30.0-dev.1
+ grpc_go_release_tag: v1.30.0 I'm going to revert this since the instructions aren't working otherwise. |
So we're waiting on |
The version is currently only used in the quick start, and the instructions only work with v1.30.0-dev.1. We can update the grpc-go version once #298 is resolved.
If you found this from the quick start guide - here's the steps to get this working Do the steps in the guide before this link then: go to the generator folder in the dir you cloned from step 1 cd grpc-go/cmd/protoc-gen-go-grpc Install protoc-gen-go-grpc go install . Now you can use the --go-grpc_out=. switch compiling your program and it will work |
Link to relevant discussion: grpc/grpc-go#3669 (comment) |
What if I don't want to clone the example repo and just want to proceed with grpc files generation assuming I've already got protobuf files generated ( update: was able to get it going with : |
https://grpc.io/docs/languages/go/quickstart/ needs updated with |
protoc-gen-go-grpc has still not been released at v1.0. You should still be using the old codegen tool at github.com/golang/protobuf to produce grpc stubs (per the quick start instructions) |
Apologies for the misinformation in my comment yesterday. We are using the new codegen tool in the quickstart guides, but it has been changed since the instructions were released. The quickstart guide instructs you to use a previous release of gRPC:
Make sure you are using this version, and are installing |
I don't believe any other changes should be required in the quick-start guide. |
Thank's for the update ! |
Thanks @dfawley, I'll try it out (I usually prefer walking through the entire thing), and then update the quick start by Monday. |
We have a multi-module repo which can be confusing. The github release page (also linked above) shows the tag for the release. |
Context: grpc/grpc-go#3688 (comment). We've known that this was coming.
Awaiting next release. It seems like the next release will be 1.31 (with 1.30 being skipped)?
Related:
The text was updated successfully, but these errors were encountered: