Add save state and screen access options to the web server #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/web-server.cc
Outdated
| } | ||
| virtual bool execute(PCSX::WebClient* client, PCSX::RequestData& request) final { | ||
| if (PCSX::g_gui == nullptr) { | ||
| client->write("HTTP/1.1 400 Bad Request\r\n\r\nSave states unavailable in CLI/no-UI mode."); |
There was a problem hiding this comment.
We might want to move the savestate code to the general UI class instead of the GUI one, but that's for another PR.
src/core/web-server.cc
Outdated
| message = | ||
| fmt::format("HTTP/1.1 200 OK\r\n\r\nState slot index {} {} successful.", slot, path); | ||
| } else { | ||
| message = fmt::format("HTTP/1.1 400 Bad Request\r\n\r\nState slot index {} {} failed.", |
There was a problem hiding this comment.
Technically that's a 500 Internal Server Error :) The request was fine, the server didn't manage to handle it properly.
src/core/web-server.cc
Outdated
| virtual ~StateExecutor() = default; | ||
| }; | ||
|
|
||
| clip::image convertScreenshotToImage(PCSX::GPU::ScreenShot&& screenshot) { |
There was a problem hiding this comment.
These should either be static, or moved as methods of the ScreenExecutor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web server GET options that allow for:
Save state access - load/save/delete/usage - NOT AVAILABLE for CLI/no-UI:
http://localhost:8080/api/v1/state/load?slot=0- loads save state from slot 0, if available. Valid slots IDs are 0-9http://localhost:8080/api/v1/state/load?name=examplename- loads named saveTITLEPREFIX_examplename.sstatehttp://localhost:8080/api/v1/state/save?slot=0- saves current state in slot 0http://localhost:8080/api/v1/state/save?name=examplename- creates/overwrites named saveTITLEPREFIX_examplename.sstatehttp://localhost:8080/api/v1/state/delete?slot=0- deletes state in slot 0, if availablehttp://localhost:8080/api/v1/state/delete?name=examplename- deletes named saveTITLEPREFIX_examplename.sstatehttp://localhost:8080/api/v1/state/usage- outputs Json that lists all existing named saves for the active title, and booleans for which save slots are in use, e.g.Screen access:
http://localhost:8080/api/v1/screen/save?filepath=d:\\screenshot.png- outputs a PNG screenshot to the given filepath.http://localhost:8080/api/v1/screen/still- outputs a PNG withContent-Type: image/png. Example refreshing<img>use-case (will affect emulator performance):