Skip to content

Commit

Permalink
require Node 18+
Browse files Browse the repository at this point in the history
This is in prep for Puppeteer 22, which requires Node 18+. [1]

grunt-contrib-internal does not yet have a version that provisions
CI with Node 18+ matrix, which has delayed/complicated changes in this
repo before as well so I'm going to opt-out from the contrib-ci
template enforcement for now. This seems to be common in half a dozen
other first-party grunt repos as well. [2]

[1]: https://github.com/puppeteer/puppeteer/blob/puppeteer-v22.10.0/packages/puppeteer-core/CHANGELOG.md#2200-2024-02-05
[2]: https://github.com/search?q=skipIfExists%20org%3Agruntjs&type=code
  • Loading branch information
Krinkle committed Jun 9, 2024
1 parent b807297 commit fcf0dc1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
node: [16, 18, 20]
node: [18, 20, 22]

steps:
- name: Clone repository
Expand Down
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,6 @@ module.exports = function(grunt) {
grunt.registerTask('test', ['jshint', 'connect', 'qunit', 'shell', 'really-test']);

// By default, lint and run all tests.
grunt.registerTask('default', ['test', 'build-contrib']);
grunt.registerTask('default', ['test', 'contrib-core', 'contrib-ci:skipIfExists']);

};
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"repository": "gruntjs/grunt-contrib-qunit",
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
},
"main": "tasks/qunit.js",
"scripts": {
Expand Down

0 comments on commit fcf0dc1

Please sign in to comment.