stop testing jessie, test tweaks to make sure no newline will hurt us…

…, yamlint foldouts

.gitignore

@@ -2,3 +2,4 @@
 __pycahce__
 *.pyc
 pytestdebug.log
+devenv

.yamllint

@@ -1,5 +1,8 @@
 extends: default
 
+ignore: |
+  devenv
+
 rules:
   braces:
     max-spaces-inside: 1

README.md

@@ -32,7 +32,7 @@ No dependencies, just note it will install `wget` to fetch the nvm installation
 Currently builds and integrates on those distros:
 
 ##### Ubuntu: 18.04, 16.04, 14.04
-##### Debian: buster, stretch, jessie
+##### Debian: buster, stretch
 ##### CentOS: 7  
 
 
@@ -87,6 +87,13 @@ and that will install global gulp and put a symlink to global $PATH for specific
 * https://molecule.readthedocs.io/en/latest/installation.html
 * [specific molecule LXD install doc](molecule/default/INSTALL.rst)
 
+as of now (28.05.2019), package versions of `molecule` and `testinfra` are incompatible
+but it's still posible to use them as long as you install `testinfra` first, like:
+
+    pip install testinfra molecule
+
+if you do it the other way around you might be getting runtime errors from python 
+on the testing phase
 
 ### Testing with lxc containers
 

handlers/main.yml

@@ -4,6 +4,5 @@
   command: "{{ nvm_dir }}/install_nvm_{{ nvm_node_version }}.script"
 
 - name: Install new global packages
-  shell : ". /root/.bashrc && {{ nvm_dir }}/versions/node/v{{ nvm_node_version }}/bin/npm install --global {{item}}"
+  shell: ". /root/.bashrc && {{ nvm_dir }}/versions/node/v{{ nvm_node_version }}/bin/npm install --global {{ item }}"
   loop: "{{ nvm_install_globally }}"
-

meta/main.yml

@@ -15,7 +15,6 @@ galaxy_info:
         - bionic
     - name: Debian
       versions:
-        - jessie
         - stretch
         - buster
     - name: EL

molecule/default/molecule.yml

@@ -16,8 +16,6 @@ platforms:
     image: debian/buster/amd64
   - name: ansible-role-node-test-instance-stretch
     image: debian/stretch/amd64
-  - name: ansible-role-node-test-instance-jessie
-    image: debian/jessie/amd64
 provisioner:
   name: ansible
   lint:

molecule/default/tests/test_default.py

@@ -10,7 +10,7 @@
 def test_node_version_ok(host):
     cmd = host.run("node -v")
     assert cmd.stderr == ''
-    assert cmd.stdout == 'v8.11.3'
+    assert cmd.stdout.rstrip() == 'v8.11.3'
 
 
 def test_global_gulp_version_ok(host):
@@ -20,23 +20,23 @@ def test_global_gulp_version_ok(host):
 
     cmd = host.run("sudo -u www-data which gulp")
     assert cmd.stderr == ''
-    assert cmd.stdout == '/usr/bin/gulp'
+    assert cmd.stdout.rstrip() == '/usr/bin/gulp'
 
 
 def test_npm_ok(host):
     cmd = host.run("npm -v")
-    assert cmd.stdout == '5.6.0'
+    assert cmd.stdout.rstrip() == '5.6.0'
 
 
 def test_user_npm_ok(host):
     with host.sudo("nvm_tester"):
         host.check_output("whoami")
         cmd = host.run("npm -v")
-        assert cmd.stdout == '5.6.0'
+        assert cmd.stdout.rstrip() == '5.6.0'
 
 
 def test_user_node_version_ok(host):
     with host.sudo("nvm_tester"):
         cmd = host.run("node -v")
         assert cmd.stderr == ''
-        assert cmd.stdout == 'v8.11.3'
+        assert cmd.stdout.rstrip() == 'v8.11.3'