Skip to content

Commit

Permalink
Update Lambda runtime and CI to Java 21
Browse files Browse the repository at this point in the history
As suggested in #209 (comment),
we want the Lambda runtime to match the Java version used by developers.

I've also updated CI to use Java 21. Ideally, we wouldn't have to do this separately
anymore, as setup-java has added partial support for asdf's .tool-versions file with
actions/setup-java#606, but unfortunately
actions/setup-java#615 means that it won't work with
Corretto version numbers.
  • Loading branch information
rtyley committed Jun 4, 2024
1 parent 7db7839 commit 5d991cc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:

# Configuring caching is also recommended.
# See https://github.com/actions/setup-java
- name: Setup Java 11
uses: actions/setup-java@v3
- name: Setup Java
uses: actions/setup-java@v4
with:
java-version: '11'
java-version: '21'
distribution: 'corretto'
cache: 'sbt'

Expand Down
2 changes: 1 addition & 1 deletion cloudformation/cfn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Resources:
- s3:GetObject
Resource: !Sub arn:aws:s3:::${ConfigBucket}/*
Handler: com.gu.anghammarad.Lambda::handleRequest
Runtime: java11
Runtime: java21
MemorySize: 512
Timeout: 30
CodeUri:
Expand Down

0 comments on commit 5d991cc

Please sign in to comment.