revert: Revert #1891 #1900
Merged
revert: Revert #1891 #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsavar
changed the title
marsavar
changed the title
marsavar
changed the title
marsavar
force-pushed
the
ms-revert-subnet
branch
2 times, most recently
from
3ed2d7d
to
1c63d49
Compare
marsavar
changed the title
akash1810
reviewed
Jun 20, 2023
There was a problem hiding this comment.
I think the prefix of the commits/PR should be revert: on this one? It's a little pedantic, I admit, however it impacts release notes. See the notes for v49.1.0.
Passing subnets to the construct causes CDK to generate custom resources Reverting this while the issue is being investigated.
marsavar
force-pushed
the
ms-revert-subnet
branch
from
e4c60c2
to
e804e80
Compare
All done! |
akash1810
approved these changes
Jun 20, 2023
|
🎉 This PR is included in version 50.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Reverts #1891, which causes deployments to fail due to custom resources being generated by CDK. It is unclear whether it is a bug, but I've filed a bug report with AWS:
subnetstoEcsRunTaskaws/aws-cdk#26013Checklist
Footnotes
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩