Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update less to version 2.1.1 #78

Closed
wants to merge 1 commit into from
Closed

Update less to version 2.1.1 #78

wants to merge 1 commit into from

Conversation

p2kmgcl
Copy link

@p2kmgcl p2kmgcl commented Nov 29, 2014

No description provided.

@guybedford
Copy link
Owner

Thanks for the PR! Have you tested this?

@p2kmgcl
Copy link
Author

p2kmgcl commented Nov 30, 2014

I tested it's general behaviour in a project I'm developing right now (loading files and importing with @import directive). If you have any standard test give it to me and I'll try :-)

@guybedford
Copy link
Owner

The basic tests I do are to open test.html in the example/www folder and ensure all the styles are loading.

@p2kmgcl
Copy link
Author

p2kmgcl commented Nov 30, 2014

I copied the stylesheet to my project and works perfectly (also loading the image).

@guybedford
Copy link
Owner

When I open www/test.html with this version, I get Unexpected token _, which is fixed by this PR I sent - less/less.js#2315.

@guybedford
Copy link
Owner

Note also that the less.Parser has been deprecated in 2.0 so that this still won't work with that fix.

Perhaps we could do something else like injecting <link> in the head that is less, or using an injection API for less somehow. Ideas welcome for how to do this.

@p2kmgcl p2kmgcl closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants