Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest j2cl and gwt and migrate to javs 11 #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vegegoku
Copy link
Contributor

This will update the repository use the following
j2cl-m-p : 0.22.0
gwt : 2.10.0
java : 11
gwt-m-p: 1.1.0

Will also update other dependencies to support java 11

@@ -23,7 +23,14 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Check out Git repository
uses: actions/checkout@v3
Copy link
Member

@FrankHossfeld FrankHossfeld Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to:

  • uses: actions/checkout@v4

uses: actions/checkout@v3

- name: Install Java and Maven
uses: actions/setup-java@v3
Copy link
Member

@FrankHossfeld FrankHossfeld Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to:

  • uses: actions/setup-java@v4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we really push the .idea folder?

<configuration>
<source>${maven.compiler.source}</source>
<target>${maven.compiler.target}</target>
<release>11</release>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the propertiy: maven.compiler.target?

<compile.testing.version>0.18</compile.testing.version>
<junit.version>4.13.1</junit.version>
<org.truth.version>0.23</org.truth.version>
<gwt.version>2.10.0</gwt.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to 2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants