Add pseudo-elements to universal selector in print media query #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the improvement. I think this is worth including within our print stylesheet. |
|
👍 |
|
@grantgeard thanks for the PR! Can you also:
If not, don't worry, we'll take care of that! :) |
|
Thanks @grantgeard, great contribution! I've updated the changes and merged this in. |
JimBobSquarePants
added a commit
to ResponsiveBP/Responsive
that referenced
this pull request
Feb 5, 2015
- Fixes issues #64 #66 - Add pseudo-elements to universal selector in print media query (h5bp/html5-boilerplate#1585) - Remove gap below iframes (h5bp/html5-boilerplate#1613) - Add vertical centering for svg (h5bp/html5-boilerplate#1453) - simplify `:focus` selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pseudo-elements
:beforeand:afterare not targeted by the universal*selector. When the page is printed the CSS properties of any pseudo-elements will only be overridden if they are being inherited from their selector. Any styles that have been defined directly on a pseudo-element are unaffected.