Removes IE8 Support - Fixes #1524 #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roblarsen
commented
Aug 23, 2016
•
roblarsen
commented
- upgrades normalizer
- upgrades jQuery
| @@ -19,6 +19,8 @@ import pkg from './package.json'; | |||
|
|
|||
| const dirs = pkg['h5bp-configs'].directories; | |||
|
|
|||
| const jQueryVersion = pkg.devDependencies.jquery.replace("^",""); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
roblarsen
force-pushed
the
removes-ie8-support
branch
from
fd10bfd
to
b5ae584
Compare
|
@roblarsen Per necolas/normalize.css#615, a new release should happen soon, you might want to wait for it. |
|
@Florian-R Thanks for letting me know! I'm not in any rush to pull this in so I can wait for that to drop. |
Closed
|
Why remove BrowseHappy? Is IE9 considered too fringe now? |
|
@JohnnyWalkerDesign It's still open for discussion (check my latest comment in #1524) But, yeah, IE9 is by some measures, even less popular than IE8. |
- upgrades normalize - upgrades jQuery commit
roblarsen
force-pushed
the
removes-ie8-support
branch
from
b5ae584
to
b539648
Compare
|
looks great! 👍 |
jeffreznik
pushed a commit
to jeffreznik/sw-test
that referenced
this pull request
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.