Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace mattermost-redux with mattermost/client #1840

Merged

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented Jan 2, 2024

fixes #1839


In the past few PRs (#1799, #1194) , we gradually bumped the Mattermost client version. However, in a certain past version of mattermost-redux, it was bundled with a lot of unnecessary dependencies, including react-native (yeah 😓).

The new Mattermost/client library now has only one dependency, form-data.

@Yukaii Yukaii force-pushed the bugfix/dev-655-replace-mattermost-redux-deps-with-client branch from bdb9838 to ed2d013 Compare January 2, 2024 08:48
@Yukaii Yukaii added this to the 2.5.1 milestone Jan 3, 2024
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii force-pushed the bugfix/dev-655-replace-mattermost-redux-deps-with-client branch from ed2d013 to 31fd655 Compare January 3, 2024 05:36
@Yukaii Yukaii merged commit 5508a93 into develop Jan 3, 2024
7 checks passed
@Yukaii Yukaii deleted the bugfix/dev-655-replace-mattermost-redux-deps-with-client branch January 3, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build a Docker image on Apple Silicon
1 participant