-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand pathspec range #186
Conversation
@Avasam this pr lgtm so far, but are you sure that we really need to do a for now, I'll remove the lock file from this pr. waiting for your response before merging. + thanks for contributing to Pycln. |
Code Climate has analyzed commit f0c3393 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 2872 2872
=========================================
Hits 2872 2872 |
Tbh I'm less familiar with poetry. If poetry.lock works anything like a package-lock.json: usually it'll be the exact versions of all dependencies to be used by the CI (so any change in poetry should come with a lockfile update). So I did what I think is the proper procedure, but clearly the CI didn't like that. As long as I can install both |
Thanks for the merge. Mind if I ask when there could be a new patch release? |
@Avasam a new Pycln release has just been released ( |
pathspec
0.10.3 is properly marked aspy.typed
. I would like to use it, but it conflicts with pycln's version range.pip install pathspec>=0.10.3
So I changed the version range to allow
pathspec ^0.10
and ranpoetry lock
to update the lock file.