-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github] Security impact field in templates #14666
Merged
hail-ci-robot
merged 4 commits into
hail-is:main
from
cjllanwarne:cjl_security_impact_templates
Sep 25, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Change Request | ||
| description: Tracker issues for new features, enhancements, or configuration changes. | ||
| labels: needs-triage | ||
| body: | ||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Description | ||
| description: What is the change? | ||
| validations: | ||
| required: true | ||
| - type: dropdown | ||
| id: security-impact | ||
| attributes: | ||
| label: Security Impact | ||
| description: Level of security impact of the change | ||
| options: | ||
| - None | ||
| - Low | ||
| - Medium | ||
| - High | ||
| - type: textarea | ||
| id: security-impact-description | ||
| attributes: | ||
| label: Security Impact Description | ||
| description: If the impact is not None, please describe the security impact and necessary mitigations | ||
| validations: | ||
| required: true | ||
| - type: checkboxes | ||
| id: appsec-signoff | ||
| attributes: | ||
| label: Appsec Signoff | ||
| description: If the security impact is High, has the change been reviewed and approved by the Appsec team? | ||
| options: | ||
| - label: Reviewed and approved | ||
| required: false | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| Fixes #<issue_number>. | ||
|
|
||
| ### Change Description | ||
|
|
||
| <!-- What is the purpose of this change? What should reviewers know? --> | ||
|
|
||
| ### Security Impact | ||
|
|
||
| <!-- Please select one of the following --> | ||
|
|
||
| - [ ] The security impact will be assessed in this PR description | ||
| - [ ] The security impact is assessed in the linked issue | ||
|
|
||
| (Reviewers: please confirm the security impact before approving) | ||
|
|
||
| <!-- If the security impact is to be assessed in the PR: | ||
| #### Security Assessment | ||
|
|
||
| - [ ] This change has a high security impact | ||
| - [ ] The impact has been assessed and approved by appsec | ||
| - [ ] This change has a medium security impact | ||
| - [ ] This change has a low security impact | ||
| - [ ] This change has no security impact | ||
|
|
||
| Please describe the security impact and necessary mitigations here. | ||
| For none/low impact: a quick one/two sentence justification of the low rating is sufficient. | ||
| For medium/high impact: please provide a detailed description of the impact and the mitigations in place. | ||
| --> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to preview this template, I get this error about
Nonebeing a reserved keyword, since it is the default option when a dropdown field is not marked asrequired.I think it would make the most sense to make this field required and change this option to be called
No impact, so that when filling out the template, we have to explicitly make a choice about what level of impact it will have. However, if we'd prefer to keep it as an optional field, we can just remove this option, andNonewill still be present in the dropdown (and will be the default option).