Check for content editable?

[asajeffrey]

The code which checks to see if keyboard events should be discarded includes checking document.activeElement.contentEditable !== 'inherit' at

reveal.js/js/reveal.js

Line 5233 in 00b0ace

var activeElementIsCE = document.activeElement && document.activeElement.contentEditable !== 'inherit';

I'm confused about this check, as contentEditable can return "true", "false" or "inherit" (https://html.spec.whatwg.org/multipage/interaction.html#attr-contenteditable) so input is discarded when contentEditable is "false".

Perhaps the test should be document.activeElement.contentEditable === 'true' or document.activeElement.isContentEditable?

This came up in servo/servo#12776.

[hakimel]

Thanks for reporting. Didn't know isContentEditable existed—I've switched to that in f138f50

The fix will be available when reveal.js 4.0 is released.

[asajeffrey]

Thanks!