Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix video-background reset when using notes plugin. #3630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zicklag
Copy link

@zicklag zicklag commented May 28, 2024

This makes the notes plugin check the difference between the states when responding to slide changes, and appropriately sends next or prev commands instead of setState in order to avoid resetting things like video backgrounds.

I needed this in my project so that I could use the notes view to remote control the slides, without really messing up the video background slide by restarting it every time I triggered the next fragment.

This makes the notes plugin check the difference between the states when
responding to slide changes, and appropriately sends `next` or `prev`
commands instead of `setState` in order to avoid resetting things like
video backgrounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant