-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ApplicationContext inaccessible in ITemplateContext #6680
Make ApplicationContext inaccessible in ITemplateContext #6680
Conversation
Signed-off-by: JohnNiang <johnniang@foxmail.com>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6680 +/- ##
============================================
- Coverage 58.18% 58.04% -0.14%
- Complexity 3774 3942 +168
============================================
Files 651 676 +25
Lines 22125 23154 +1029
Branches 1538 1579 +41
============================================
+ Hits 12873 13440 +567
- Misses 8641 9090 +449
- Partials 611 624 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind api-change |
What type of PR is this?
/kind improvement
/area core
/area plugin
/milestone 2.20.x
What this PR does / why we need it:
This PR disables access to ApplicationContext using ITemplateContext.
Does this PR introduce a user-facing change?