Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to the Safari undefined string bug #440

Closed
wants to merge 1 commit into from
Closed

Quick fix to the Safari undefined string bug #440

wants to merge 1 commit into from

Conversation

GianlucaGuarini
Copy link

If the string to quote is undefined Handlebars throws an error only on Safari, this patch fixes the problem returning empty quotes for the undefined strings

@leonardehrenfried
Copy link

I think the issue in question is #373. This is really strange and I just managed to create a minimal test case for it: http://jsbin.com/ezidox/25

Note that the case only fails with Safari 6 and only if the inspector is closed.

Furthermore, it looks to me like Safari starts failing only after calling the function a few times. This suggests to me, that maybe it's due to a Nitro optimisation gone wrong.

@kpdecker
Copy link
Collaborator

Assuming that this issue is deterministic then it was resolved by 94e7004 which is available in rc3. I couldn't even begin to tell you WHY that might have resolved it but after bisecting this it seems pretty reliable that this fixed this issue.

Closing this PR as it feels like it actually masks the incorrect behavior where we actually want things to fail as there is something seriously wrong if that method receives undefined values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants