Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped v8.4.0 #139

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Bumped v8.4.0 #139

merged 1 commit into from
Sep 28, 2021

Conversation

lauraseidler
Copy link
Collaborator

Hey,

any chance to get the changes from #138 out as a release? I've installed from GitHub by commit hash until now, but it's now making some problems, so I'd love to have an npm release :)

Thanks!

@mcollina
Copy link
Collaborator

I've added you to npm so you can publish yourself.

@mcollina
Copy link
Collaborator

Sorry about this, I'm not using this anymore and doing a bad job at releasing it! I hope you don't mind.

@lauraseidler
Copy link
Collaborator Author

@mcollina no problem at all, thanks! Anything in particular I need to be aware of?

@mcollina
Copy link
Collaborator

nope ;), just go ahead and ship it. We usually push version bumps straight to master at publish time, no pr.

@lauraseidler
Copy link
Collaborator Author

Cheers! I will merge this one as it's already there, will push directly for the next one :)

Btw, I see that travis builds aren't running anymore (travis-ci.org not a thing anymore) - given that the build is not super complicated, I thought instead of moving to travis-ci.com, GitHub actions might be an option? WDYT?

@lauraseidler lauraseidler merged commit b09a3c2 into hapijs:master Sep 28, 2021
@lauraseidler lauraseidler deleted the bump-8.4.0 branch September 28, 2021 16:11
@mcollina
Copy link
Collaborator

go for actions!

@mcollina
Copy link
Collaborator

(also add yourself as a contributor to package.json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants