Use WHATWG URL for request.url #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanongil
added
feature
|
Note: We could probably remove the |
|
I changed it to be more consistent and less flexible. |
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 24, 2019
Since version 18 (released in January), Hapi's `request.url` returns the parsed URL, so `parse` is not needed. Ref: - https://hapijs.com/api#-requesturl - hapijs/hapi#3822
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look into what it would take to update hapi to use the WHATWG URL API since
Url.parse()is being deprecated, and node 8 already supports the replacement API.As far as I can tell, the only directly affected api is the
request.urlproperty, and thesetUrl()method.PR details:
Url.parse()has been replaced with the new URL API. There is no legacy support.route.queryParseroption to retain ability to customize the query parsing. The return value is validated so thatrequest.querywill always be an object.request.urlproperty is no longer relative, since the URL constructor won't create relative URLs.setUrlthrows abadRequesterror if the URL parsing fails.