-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API deprecations #268
Comments
I'll go over the list and let you know. |
I wonder how often the For those who don't, |
Yes, there are a few methods that are basically wrappers or direct alias to javascript / node features. We might want to prune some of these as well. While they might make sense to hapi developers, when encountered in some code, the ES version should be easier to grok for new users. |
It would seem that some of these are used in the extended hapi universe. Eg. I found Further analysis shows that those are the only additional methods used in any public |
Leaving |
I don't think we need to publish release notes for this, but you can if you want. |
@hueniverse Why would there not be release notes for this? I just went to look back at the documentation for I finally came across this issue and found the corresponding commit. I don't see any of these functions as ever being marked |
hoek has always been an internal hapi utility belt. I do not treat it as a generally useful module. Following hapi policies, a The maintainer of this module might still choose to publish release notes if he finds that useful but I think this issue is enough documentation. |
I too had to hunt through the commit logs to find where the methods were removed, and wasted at least 15 minutes |
@brycehendrix If you're using hoek directly that probably means you depend on it in your project. Those methods didn't magically disappear, it was done in a breaking release. Should we conclude that you upgrade your dependencies on a major version without even looking at what changed? |
@Marsup They're saying that in order to upgrade the module, they had to hunt around a series of commits, issues, etc. to find what was removed. People are using this and many other Hapi libraries (like wreck) in production code. It still blows my mind that there's no I'm not sure why the maintainers here are so against keeping a changelog. Wouldn't this help with internal updates across Hapi libraries as well as give transparency to your community?
I wonder why this was even open sourced in the first place. When you release a project, people will use it. TL;DR: Your community matters. Release Notes / CHANGELOG matter. |
We do not keep a changelog. We properly use issues and labels. There is a limit to how much we can work to educate people about this. It has been mentioned many times before. There is a Keeping changelog is extra effort that duplicates existing information. If someone wants to put in the effort to surface all these changes into the hapijs.com site the same way we do for core, PRs are welcomed. But complaining that other people are not doing the work for you will never fly with me. If you don't like how the hapi.js community manages its FREE open source work, don't use it. No one owes you anything. If you want to help improve things, contribute your time or your money. This is particularly true for people working for major corporations with plenty of resources who are benefiting immensely from our work but giving back nothing. TL;DR People who contribute nothing do not get to tell us that our community matters or how to run it. Using my free work one-sidedly does not make you part of my community. |
@nathanchapman With properly declared dependencies across the board, modules using hoek 5 methods will have it, and modules using hoek 6 won't but they're indeed okay with it. I'm still puzzled as to where is the problem, unless you or one of your modules just assumed hoek would pop out of nowhere. |
Remove unused:
formatStack()
formatTrace()
callStack()
displayStack()
abort()
escapeJavaScript()
format()
transform()
isInteger()
- was mapped toNumber.isSafeInteger()
inherits()
- was mapped toUtil.inherits()
mapToObject()
shallow()
- can be replaced withObject.assign({}, obj)
unique
Move to b64:
base64urlEncode()
base64urlDecode()
The text was updated successfully, but these errors were encountered: