Update index.js

[ainesophaur]

switch from using this.redis_pings in favor of this.redis_ping()

[msimerson]

Should this.redis_ping() still be in register()? If it's just throwing an error at startup, it's not doing any good.

[ainesophaur]

In my testing, the race condition always occurs when calling redis_ping in the register. The init hooks for the redis plugin doesn't seem to complete before ping is called when interacting with redis in the register function

…

On Tue, Nov 22, 2022, 9:42 AM Matt Simerson ***@***.***> wrote: Should this.redis_ping() still be in register()? If it's just throwing an error at startup, it's not doing any good. — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDYC5SQPVH7L5BM2XCHWGTWJTLWHANCNFSM6AAAAAASH3IFME> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[msimerson]

That sounds like your answer is yes.

[ainesophaur]

Actually, no. I mistakenly left it in when I was doing a 3 way merge from my local branch to my GH fork. I just made commit 0d5ed36 which removes the call within the register method.

[superman20]

I'm a Windows user and don't use redis at all. The new construct throws an uncaught error every time rendering startup impossible. Not calling:

this.merge_redis_ini();
this.redis_ping();
this.register_hook('init_master',  'init_redis_plugin');
this.register_hook('init_child',   'init_redis_plugin');

solves the problem for me (and incidentally gets rid of the periodic connection error messages to redis). I have a patch that adds a disabled option to the config and everywhere that is true, it skips any redis calls (including the ones above in register), but that might not be quite what you're looking for.

Edited for clarity: the error I get is the "redis not initialized" error at haraka-plugin-redis\index.js:148