Switch internal parser to email-addresses #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you've got some upstream PRs merged. Is this just waiting on an upstream release now? |
|
No. The last issue I posted on the repo is still an issue.
Regardless, it doesn't allow us to do SMTPUTF8 in Haraka, but I'll post on
that issue why.
…On Mon, May 22, 2017 at 2:26 PM, Matt Simerson ***@***.***> wrote:
I see
<https://github.com/jackbowman/email-addresses/pulls?q=is%3Apr+is%3Aclosed>
that you've got some upstream PRs merged. Is this just waiting on an
upstream release now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAobY2LX-JOGrVmutWV5Q8HpoAt6VQc_ks5r8dNSgaJpZM4MKUCh>
.
|
But those are not yet merged/published? And so neither can this, yet? |
|
Never mind. I fixed the lint issues but other issues remain. |
|
Correct. I'm still waiting on those changes being merged. I ran the tests against a local version.
When they merge them I'll post on this PR.
… On Jun 16, 2017, at 10:28 PM, Matt Simerson ***@***.***> wrote:
Never mind. I fixed the lint issues but other issues remain.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
added 3 commits
June 21, 2017 18:04
…rfc2822 into use_email_addresses
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 90.05% 87.82% -2.24%
==========================================
Files 1 1
Lines 171 115 -56
Branches 44 29 -15
==========================================
- Hits 154 101 -53
+ Misses 17 14 -3
Continue to review full report at Codecov.
|
|
$ npm publish
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch switches the internal parser to using email-addresses.
It is currently waiting on a few changes required to the upstream library, and may require a few more tweaks once those go in, as such, tests currently fail so hold off on merging.