Allow comma in display name #52
Conversation
|
I'm not strongly opposed to allowing this, but after perusing RFC 5322 quickly, and considering the security aspects of the Display Name, I'm not convinced it should default to enabled. I think the feature should default to off. |
|
That sounds reasonable. I decided to add an options object after the |
|
Switching to an object for passing in arguments is the right approach. The called function can check the argument type to maintain backwards compatibility. |
|
Yeah it's nicer, with the latest commit I've changed it to allow for an object to be passed instead and at the same time also accept anything else and use that as the startAt parameter to keep backwards compatibility. |
|
And while you're at it, please update Changes.md and bump the version number in package.json. |
- feat: option to allow comma in display name #52 - dep(email-addresses): bump from 4.0.0 to 5.0.0 #58 - chore: replace a couple regex with slice (perf & sec) #63 - test: a few more tests to boost coverage #63 - test: drop node 10, add node 16 #61 - ci: restore GH workflow for PRs #57 - ci: add dependabot.yml #55 - doc: add inline documentation for parse #60 - doc(Changes): make PR #s into links #54 - doc(README): add result of console.logs #56 - doc(README): add links to RFC 2822, 5322 #53 - doc(README): enabled syntax highlighting with code fences #51
This is a similar PR as I made earlier #47, but this time it allows
,in the display name.The feature was added to the email-addresses library with this PR: jackbearheart/email-addresses#54