[BREAKING]: Remove WaitForTimeoutAsync (#2595)

hardkoded · Apr 11, 2024 · eddc391 · eddc391
1 parent 391e196
commit eddc391
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 153 deletions.
diff --git a/lib/PuppeteerSharp.Tests/WaitTaskTests/FrameWaitForTimeoutTests.cs b/lib/PuppeteerSharp.Tests/WaitTaskTests/FrameWaitForTimeoutTests.cs
diff --git a/lib/PuppeteerSharp.Tests/WaitTaskTests/PageWaitForTests.cs b/lib/PuppeteerSharp.Tests/WaitTaskTests/PageWaitForTests.cs
diff --git a/lib/PuppeteerSharp.Tests/WaitTaskTests/PageWaitForTimeoutTests.cs b/lib/PuppeteerSharp.Tests/WaitTaskTests/PageWaitForTimeoutTests.cs
diff --git a/lib/PuppeteerSharp/Frame.cs b/lib/PuppeteerSharp/Frame.cs
@@ -135,9 +135,6 @@ public Task<IElementHandle> WaitForXPathAsync(string xpath, WaitForSelectorOptio
             return WaitForSelectorAsync($"xpath/{xpath}", options);
         }
 
-        /// <inheritdoc/>
-        public Task WaitForTimeoutAsync(int milliseconds) => Task.Delay(milliseconds);
-
         /// <inheritdoc/>
         public Task<IJSHandle> WaitForFunctionAsync(string script, WaitForFunctionOptions options, params object[] args)
         {

diff --git a/lib/PuppeteerSharp/IFrame.cs b/lib/PuppeteerSharp/IFrame.cs
@@ -389,15 +389,6 @@ public interface IFrame
         /// <exception cref="WaitTaskTimeoutException">If timeout occurred.</exception>
         Task<IElementHandle> WaitForSelectorAsync(string selector, WaitForSelectorOptions options = null);
 
-        /// <summary>
-        /// Waits for a timeout.
-        /// </summary>
-        /// <param name="milliseconds">The amount of time to wait.</param>
-        /// <returns>A task that resolves when after the timeout.</returns>
-        /// <seealso cref="IPage.WaitForTimeoutAsync(int)"/>
-        /// <exception cref="WaitTaskTimeoutException">If timeout occurred.</exception>
-        Task WaitForTimeoutAsync(int milliseconds);
-
         /// <summary>
         /// Waits for a selector to be added to the DOM.
         /// </summary>

diff --git a/lib/PuppeteerSharp/IPage.cs b/lib/PuppeteerSharp/IPage.cs
@@ -1393,14 +1393,6 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <seealso cref="IFrame.WaitForSelectorAsync(string, WaitForSelectorOptions)"/>
         Task<IElementHandle> WaitForSelectorAsync(string selector, WaitForSelectorOptions options = null);
 
-        /// <summary>
-        /// Waits for a timeout.
-        /// </summary>
-        /// <param name="milliseconds">The amount of time to wait.</param>
-        /// <returns>A task that resolves when after the timeout.</returns>
-        /// <seealso cref="IFrame.WaitForTimeoutAsync(int)"/>
-        Task WaitForTimeoutAsync(int milliseconds);
-
         /// <summary>
         /// Waits for a xpath selector to be added to the DOM.
         /// </summary>

diff --git a/lib/PuppeteerSharp/Page.cs b/lib/PuppeteerSharp/Page.cs
@@ -659,10 +659,6 @@ public Task<IResponse> ReloadAsync(int? timeout = null, WaitUntilNavigation[] wa
         public Task<string[]> SelectAsync(string selector, params string[] values)
             => MainFrame.SelectAsync(selector, values);
 
-        /// <inheritdoc/>
-        public Task WaitForTimeoutAsync(int milliseconds)
-            => MainFrame.WaitForTimeoutAsync(milliseconds);
-
         /// <inheritdoc/>
         public Task<IJSHandle> WaitForFunctionAsync(string script, WaitForFunctionOptions options = null, params object[] args)
             => MainFrame.WaitForFunctionAsync(script, options ?? new WaitForFunctionOptions(), args);