Fix request interception with complex PostData #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8253e07.
kblok
force-pushed
the
fix-request-interception-with-complex-post-data
branch
from
35e7ac4
to
c986429
Compare
kblok
force-pushed
the
fix-request-interception-with-complex-post-data
branch
from
6d2ec60
to
2fc251b
Compare
kblok
force-pushed
the
fix-request-interception-with-complex-post-data
branch
from
2fc251b
to
7c533f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding the close reason to the
Navigating frame was detachedexception to improve debugging.A new
Requestclass was created for the CDP protocol to separate it from thePayloadused in the API. This internal class has thePostDataas an object instead of a string to handle Unicode messages. This property is used to initializeRequest.PostData, which is already anobject.closes #2693